Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout to SSHConnector #644

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Added timeout to SSHConnector #644

wants to merge 1 commit into from

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Jan 20, 2025

This commit adds the timeout in the asyncssh.connect() call. The user chooses the time to wait using the connectTimeout option. If the retry is enabled, the wait time increases at each attempt.

Updated documentation checksum because the connectTimeout option was added in the SSHConnector schema

@LanderOtto LanderOtto marked this pull request as draft January 20, 2025 18:08
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.33%. Comparing base (eb19e9a) to head (6333375).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/cwl/translator.py 0.00% 2 Missing and 2 partials ⚠️
streamflow/deployment/connector/ssh.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   71.35%   71.33%   -0.02%     
==========================================
  Files          88       88              
  Lines       11310    11315       +5     
  Branches     1968     1970       +2     
==========================================
+ Hits         8070     8072       +2     
- Misses       2784     2786       +2     
- Partials      456      457       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto force-pushed the feat/ssh-timeout branch 2 times, most recently from 1f68209 to d2f376d Compare January 22, 2025 11:48
…er chooses the time to wait using the `connectTimeout` option. If the `retry` is enabled, the time to wait is increased at each attempt.

Updated documentation checksum because the `connectTimeout` option was added in the `SSHConnector` schema
@LanderOtto LanderOtto force-pushed the feat/ssh-timeout branch 2 times, most recently from 6333375 to 2ba9820 Compare January 24, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant