-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote files handling #648
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 71.37% 71.44% +0.07%
==========================================
Files 88 88
Lines 11310 11345 +35
Branches 1968 1981 +13
==========================================
+ Hits 8073 8106 +33
- Misses 2782 2785 +3
+ Partials 455 454 -1 ☔ View full report in Codecov by Sentry. |
ff004f8
to
33c922c
Compare
else: | ||
return path_processor.join( | ||
new_dir, | ||
*os.path.relpath(urllib.parse.unquote(path[7:]), old_dir).split( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the slicing path[7:]
in the else
branch
a019a42
to
89823bb
Compare
…ls.File` objects
d1d1696
to
9351079
Compare
2b780f0
to
800c5c1
Compare
2e14fee
to
4deafee
Compare
4deafee
to
2d5ebdf
Compare
This commit fixes several problems with remote ports.
SecondaryFile
objects were not registered in theDataManager
file systemremap_path
did not work correctly when the path was not an URIDirectory
object has thelisting
field to list files and directories. These files can exist or not; in the last case, they are created. Before this commit, when a file existed, it was copied twice: once from the copy of the directory and once from the copy of the file itself._get_inner_path
functions defined indata/manager.py
andremotepath.py
._get_inner_path
method of theRemoteStreamFlowPath
class. Now it correctly handles data when they are not mounted from the inner location (e.g., when some input data is already stored inside a target container image).DataManager
class when created by the relative functions, i.e.,write_remote_file
andcreate_remote_directory
in thecwl/utils.py
module.File
withsecondaryFiles
,Directory
and literalDirectory
.