Improve StreamFlow on Kubernetes #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
update-helm-chart
branch
from
5eef4be to
8b59995
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
GlassOfWhiskey
force-pushed
the
update-helm-chart
branch
6 times, most recently
from
eda8219 to
4685214
Compare
GlassOfWhiskey
force-pushed
the
update-helm-chart
branch
from
4685214 to
a4b3f44
Compare
This commit heavily refactors the StreamFlow Helm chart to simplify its deployment on top of Kubernetes clusters. In addition, this commit adds a `networkPolicy` flag to control the behaviour of CWL `DockerRequirement` objects into Kubernetes `Pod` items. Normally, the CWL `NetworkAccess` requirement is enforced through Kubernetes `NetworkPolicy` objects. However, `NetworkPolicy` objects regulate the network security inside a cluster, and giving the StreamFlow `Pod` permissions to create/delete them may result in unwanted security flaws. The `networkPolicy` option can be set to `False` to ignore the CWL `NetworkAccess` enforcement in such cases.
GlassOfWhiskey
force-pushed
the
update-helm-chart
branch
from
a4b3f44 to
5d4a78e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit heavily refactors the StreamFlow Helm chart to simplify its deployment on top of Kubernetes clusters.
In addition, this commit adds a
networkPolicyflag to control the behaviour of CWLDockerRequirementobjects into KubernetesPoditems. Normally, the CWLNetworkAccessrequirement is enforced through KubernetesNetworkPolicyobjects. However,NetworkPolicyobjects regulate the network security inside a cluster, and giving the StreamFlowPodpermissions to create/delete them may result in unwanted security flaws. ThenetworkPolicyoption can be set toFalseto ignore the CWLNetworkAccessenforcement in such cases.