Least privilege #986
Open
Least privilege #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think 12 hours is too long for privileged access to anything
galund
reviewed
Feb 7, 2025
| @@ -32,7 +32,7 @@ Your team should: | |||
| - create the roles or credentials with the least possible privilege, with only necessary permissions required for normal users to perform their day-to-day jobs | |||
| - use the role or credentials with the least possible privilege as the default option | |||
| - use just-in-time (JIT) access provisioning to grant users an on-demand, time-limited privileged role or security token to access the privileged resources | |||
| - make sure session time of the privileged access is set to no more than 12 hours, and/or terminates when the user logs out of their laptop | |||
| - make sure session time of the privileged access is set to no more than 30 minutes, and/or terminates when the user logs out of their laptop | |||
There was a problem hiding this comment.
Suggested change
| - make sure session time of the privileged access is set to no more than 30 minutes, and/or terminates when the user logs out of their laptop | |
| - make sure session time of the privileged access (in non-development environments) is set to no more than 30 minutes, and/or terminates when the user logs out of their laptop |
|
Noticed there's also a '12 hours' at line 47 that might want to be consistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rephrased the top line and reduced the privileged access session time.