Skip to content
Tests

Improve naming of File Upload classes and regroup state styles #13348

Sign in to view logs

Improve naming of File Upload classes and regroup state styles

Improve naming of File Upload classes and regroup state styles #13348

Triggered via pull request February 7, 2025 15:52
@patrickpatrickpatrickpatrickpatrickpatrick
synchronize #5705
file-upload-css-refactoring
Status Failure
Total duration 5m 57s
Artifacts 5

tests.yml

on: pull_request
Matrix: Install
Matrix: Build
Diff changes to npm package  /  Generate diff
1m 10s
Diff changes to npm package / Generate diff
Stats comment  /  Generate stats
38s
Stats comment / Generate stats
Matrix: lint
Percy  /  Send screenshots
1m 27s
Percy / Send screenshots
Matrix: Bundler integrations / Test tree shaking
Matrix: package
Matrix: test
Matrix: verify
Fit to window
Zoom out
Zoom in

Annotations

20 errors
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › wrapper element › moves the file input inside of the wrapper element: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L68
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:68:40)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › file input › sets tabindex to -1: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L80
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:80:42)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when selecting a file › updates the file input value: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L162
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:162:37)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when selecting multiple files › updates the file input value: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L211
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:211:37)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › disabled state syncing › disables the button if the input is disabled programatically: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L466
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:466:11)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › disabled state syncing › enables the button if the input is enabled programatically: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L490
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:490:11)
JavaScript component tests (ubuntu-22.04)
Process completed with exit code 1.
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › wrapper element › moves the file input inside of the wrapper element: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L68
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:68:40)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › on page load › file input › sets tabindex to -1: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L80
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:80:42)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when clicking the choose file button › opens the file picker: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L134
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:134:39
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when selecting a file › updates the file input value: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L162
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:162:37)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › when selecting multiple files › updates the file input value: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L211
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:211:37)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › disabled state syncing › disables the button if the input is disabled programatically: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L466
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:466:11)
/components/file-upload › /components/file-upload/preview › when JavaScript is available › disabled state syncing › enables the button if the input is enabled programatically: packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js#L490
Error: failed to find element matching selector ".govuk-file-upload" at CdpElementHandle.$eval (node_modules/puppeteer-core/src/api/ElementHandle.ts:497:13) at CdpFrame.$eval (node_modules/puppeteer-core/src/api/Frame.ts:631:12) at CdpPage.$eval (node_modules/puppeteer-core/src/api/Page.ts:1307:12) at Object.<anonymous> (packages/govuk-frontend/src/govuk/components/file-upload/file-upload.puppeteer.test.js:490:11)
JavaScript component tests (windows-latest)
Process completed with exit code 1.

Artifacts

Produced during runtime
Name Size
JavaScript behaviour tests coverage (ubuntu-22.04)
243 KB
JavaScript behaviour tests coverage (windows-latest)
243 KB
JavaScript unit tests coverage (ubuntu-22.04)
222 KB
JavaScript unit tests coverage (windows-latest)
222 KB
Package diff
16.2 KB