Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeguard around git diff scan #154

Closed
wants to merge 1 commit into from
Closed

Add safeguard around git diff scan #154

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2023

This is to prevent the scan to be run multiple times and show more than once in Magit's buffer

Fixes #145 and #127

I just went back to work from vacation and stumbled on this problem again (guess I hit g too often...).

This is to prevent the scan to be run multiple times and show more than once in
Magit's buffer

Fixes #145 && #127
@alphapapa
Copy link
Owner

Thanks.

@alphapapa alphapapa self-assigned this Sep 19, 2023
@alphapapa alphapapa added bug Something isn't working enhancement New feature or request labels Sep 19, 2023
@alphapapa alphapapa added this to the 1.8 milestone Sep 19, 2023
@ghost ghost closed this by deleting the head repository Jan 23, 2024
@alphapapa
Copy link
Owner

@mpaulmier What happened here?

@mpaulmier
Copy link
Contributor

mpaulmier commented Jan 24, 2024

Oh yeah, sorry about that. In an attempt to merge my github accounts, I deleted the account that created this PR because it was becoming too annoying to manage both.

I can reopen the PRs (this one and #144) under this account if you want or you can take the code and commit it directly if you want.

EDIT: Funny that the PR was closed, I had one in another project that was kept alive even though the creator is now @ghost

@alphapapa
Copy link
Owner

I understand. Well, if it's not too much trouble, I'd be grateful if you'd reopen them. I do intend to merge them, I just have a lot of projects right now. I appreciate your patience. (FWIW I've recently merged some 3-year-old PRs on other projects. I do get to them eventually...)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branched todos section may appear multiple times when reloading too quickly
2 participants