Support for tsvector #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first and basic step.
A tsvector can be defined in Python with a list of tuple (lexeme, positions). positions is a list of position, either int or str (e.g. '1A').
Full example:
[ ('aà', ['1A', '3A']), ('b', ['2A']), ]A lot of things are missing right now:
For encoding, lexemes should be encoded using client connection, but the automatic encoder isn't made for that. Maybe client_encoding could be passed as optional kwargs to every formatter?
For the last point, it's good to remember that tsvector are sorted, and I've no intention of supporting the creation of such a thing (see to_tsvector) which is very complicated to replicate in Python.