CGNAT Exit and integration test #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now this is manually adding all possible external ips on the exit subnet, which we're hoping to avoid since that gets clunky real fast.
ch-iara
force-pushed
the
chiara/cgnat-exits
branch
2 times, most recently
from
beba305 to
9569820
Compare
jkilpatr
approved these changes
Feb 17, 2025
| @@ -368,6 +368,51 @@ pub fn teardown_snat( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Sets up the CGNAT rules for the exit server run on startup | |||
There was a problem hiding this comment.
It would be nice if this comment explicitly noted that we're handing the cgnat tasks off to the kernel to allocate connections between the internal and external subnets.
rita_exit/src/rita_loop/mod.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| // gets the range of possible ips for a given subnet. by convention the static assignments in cgnat mode should be | ||
| // on the ends of the assignable range to make random assignment less complex. TODO: endpoint to set static ips should |
There was a problem hiding this comment.
I think this todo is completed and can be cleaned up
|
looks like the multi exit test needs a fix. |
Removing some extra cruft now that CGNAT mode does not explicitly assign or keep track of clients <-> external ips
ch-iara
force-pushed
the
chiara/cgnat-exits
branch
from
9569820 to
3eb4503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now this is manually adding all possible external ips on the exit subnet, which we're hoping to avoid since that gets clunky real fast.