Error handling

alvarosanchez · Jan 12, 2015 · 34848fc · 34848fc
1 parent a4843c9
commit 34848fc
Showing 1 changed file with 26 additions and 19 deletions.
diff --git a/grails-app/controllers/hipchat/addon/WebhookController.groovy b/grails-app/controllers/hipchat/addon/WebhookController.groovy
@@ -31,28 +31,35 @@ class WebhookController {
 
                 if (matcher) {
                     matcher.each {
-                        String issueKey = it[0]
-                        response = jira.get(path: "/issue/${issueKey}")
-                        String issueTypeIcon = response.json.fields.issuetype.iconUrl
-                        String summary = response.json.fields.summary
-                        def resolution = response.json.fields.resolution
-                        def status = response.json.fields.status
-                        def assignee = response.json.fields.assignee
-
-                        String message = """
-                            <img src="${issueTypeIcon}"/> <strong><a href="${tenant.jiraUrl}/browse/${issueKey}">${summary}</a></strong> ${resolution?"\u2713":''}
-                            <ul>
-                                <li><em>Status</em>: <img src="${status.iconUrl}"/> ${status.name}</li>
-                                ${resolution?'': assignee ? "<li><em>Assignee</em>: <img src=\"${assignee.avatarUrls['16x16']}\" /> ${assignee.displayName}" : ''}
-                            </ul>
-                        """.trim()
-
-                        sendRoomNotification(hipchat, roomId, message)
-
-                        render status: 200
+                        try {
+                            String issueKey = it[0]
+                            response = jira.get(path: "/issue/${issueKey}")
+                            String issueTypeIcon = response.json.fields.issuetype.iconUrl
+                            String summary = response.json.fields.summary
+                            def resolution = response.json.fields.resolution
+                            def status = response.json.fields.status
+                            def assignee = response.json.fields.assignee
+
+                            String message = """
+                                <img src="${issueTypeIcon}"/> <strong><a href="${tenant.jiraUrl}/browse/${issueKey}">${summary}</a></strong> ${resolution?"\u2713":''}
+                                <ul>
+                                    <li><em>Status</em>: <img src="${status.iconUrl}"/> ${status.name}</li>
+                                    ${resolution?'': assignee ? "<li><em>Assignee</em>: <img src=\"${assignee.avatarUrls['16x16']}\" /> ${assignee.displayName}" : ''}
+                                </ul>
+                            """.trim()
+
+                            sendRoomNotification(hipchat, roomId, message)
+                        } catch (exception) {
+                            //Tasty!
+                        }
+
                     }
                 }
             }
+
+            render status: 200
+        } else {
+            render status: 404
         }
 
     }