Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-202461 Generate feature flags with new pattern featureFlagKey = "" #4

Open
wants to merge 190 commits into
base: master
Choose a base branch
from

Conversation

ling-alan-huang
Copy link

@ling-alan-huang ling-alan-huang commented Nov 23, 2023

Tested ci sf here: ling-alan-huang#2283

AkramYoussoufi and others added 30 commits November 22, 2023 08:20
…csPortalInstanceLifecycleListener by making it extending InitialRequestPortalInstanceLifecycleListener to avoid NPE caused by PortletFileRepositoryUtil.fetchPortletRepository while deleteBackgroundTask during startup.
… children of TranslationEntry to avoid leftover data when discarding TranslationEntry
…Return the JournalArticle so all related entities can be cleaned up properly.
…as part of the workflow, but we should not define JournalArticle as the child because TranslationEntry doesn't own it.
…hen reviewing a Layout change with multiple locales
carolmariaabb and others added 28 commits November 22, 2023 16:21
…ct definition or submitting a new object entry because the contextAcceptLanguage depends on it
…move lastModified logic from NPMJavaScriptAwarePortalWebResources to NPMJavaScriptLastModifiedUtil and change serviceTracker usages to be an util method call. (Note: the service trackers were removed because there was only one component with the JavaScriptAwarePortalWebResources service)
…it does not have any usages

# breaking_change_report

## What modules/apps/frontend-js/frontend-js-loader-modules-extender-api/scr/main/java/com/liferay/frontend/js/loader/modules/extender/npm/JavaScriptAwarePortalWebResources.java

modules/apps/frontend-js/frontend-js-loader-modules-extender-api/scr/main/java/com/liferay/frontend/js/loader/modules/extender/npm/JavaScriptAwarePortalWebResources.java now does not exist anymore

## Why

this change was made because that was just one component implementing this interface

----
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.