forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-202461 Generate feature flags with new pattern featureFlagKey = ""
#4
Open
ling-alan-huang
wants to merge
190
commits into
alvarosaugarlr:master
Choose a base branch
from
ling-alan-huang:LPS-189045-LPS-196299-i4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPS-202461 Generate feature flags with new pattern featureFlagKey = ""
#4
ling-alan-huang
wants to merge
190
commits into
alvarosaugarlr:master
from
ling-alan-huang:LPS-189045-LPS-196299-i4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for APIBuilder Component
…napshot in PortletFileRepositoryUtil
…csPortalInstanceLifecycleListener by making it extending InitialRequestPortalInstanceLifecycleListener to avoid NPE caused by PortletFileRepositoryUtil.fetchPortletRepository while deleteBackgroundTask during startup.
…bleReferenceDefinition
…rsionTableReferenceDefinition
…cordVersionTableReferenceDefinition
… children of TranslationEntry to avoid leftover data when discarding TranslationEntry
…Return the JournalArticle so all related entities can be cleaned up properly.
…as part of the workflow, but we should not define JournalArticle as the child because TranslationEntry doesn't own it.
…ll be removed when JournalArticle is removed
…hen reviewing a Layout change with multiple locales
…ct definition or submitting a new object entry because the contextAcceptLanguage depends on it
…s using IA (DALL-E)
…move lastModified logic from NPMJavaScriptAwarePortalWebResources to NPMJavaScriptLastModifiedUtil and change serviceTracker usages to be an util method call. (Note: the service trackers were removed because there was only one component with the JavaScriptAwarePortalWebResources service)
…it does not have any usages # breaking_change_report ## What modules/apps/frontend-js/frontend-js-loader-modules-extender-api/scr/main/java/com/liferay/frontend/js/loader/modules/extender/npm/JavaScriptAwarePortalWebResources.java modules/apps/frontend-js/frontend-js-loader-modules-extender-api/scr/main/java/com/liferay/frontend/js/loader/modules/extender/npm/JavaScriptAwarePortalWebResources.java now does not exist anymore ## Why this change was made because that was just one component implementing this interface ----
For LPS-189045
For LPS-196299
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested ci sf here: ling-alan-huang#2283