feat: Add full ESM support via an import export condition
#755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/next-intl/package.json # packages/use-intl/package.json
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
commented
Jan 3, 2024
| @@ -21,7 +21,7 @@ | |||
| "test": "TZ=Europe/Berlin vitest", | |||
| "lint": "pnpm run lint:source && pnpm run lint:package", | |||
| "lint:source": "eslint src test && tsc --noEmit", | |||
| "lint:package": "publint && attw --pack", | |||
packages/use-intl/package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "test": "TZ=Europe/Berlin vitest", | |||
| "lint": "pnpm run lint:source && pnpm run lint:package", | |||
| "lint:source": "eslint src test && tsc --noEmit", | |||
| "lint:package": "publint && attw --pack", | |||
amannn
changed the title
import export condition for ESM supportimport export condition to enable ESM support
amannn
changed the title
import export condition to enable ESM supportimport export condition
…xt-intl missing atm)
# Conflicts: # packages/next-intl/package.json # packages/next-intl/plugin.d.ts # packages/next-intl/src/plugin.tsx # packages/use-intl/package.json # pnpm-lock.yaml
amannn
commented
Jun 10, 2024
| /** @type import('rollup').RollupOptions */ | ||
| const config = { | ||
| input, | ||
| external: [/node_modules/, ...external], | ||
| output: { | ||
| dir: outDir + env, | ||
| format: 'cjs', | ||
| format, | ||
| entryFileNames: '[name]' + (format === 'es' ? '.mjs' : '.js'), |
amannn
commented
Jun 10, 2024
|
Superseded by #1115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support ESM partially. This PR investigates switching to bunchee in order to enable full ESM support.
TODO
productionenvironment instead and ship full errors by default for other entry points? That would result in Next.js getting the smallest build, test runners getting unminified errors—and, users ofuse-intl(e.g.react-native) potentially also unminified errors. Should we ship a version where a condition liketypeof process !== 'undefined' && process.env.NODE_ENV === 'production'is included in the bundle? Maybe shipdevelopment,productionas well asdefaultwith with an uncompiled condition liketypeof process !== 'undefined' && process.env.NODE_ENV === 'production' ?to support everything.