Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test_manager.py to allow docker executables to be run #289

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ehinrichs
Copy link
Contributor

Updated test_manager.py to allow docker executables to be run and changed mount type from delegated to cached to help ensure file consistency between host and container

Updated test_manager.py to allow docker executables to be run and changed mount type from delegated to cached to help ensure file consistency between host and container
@ehinrichs ehinrichs requested a review from jd-moulton January 15, 2025 15:15
Copy link
Member

@jd-moulton jd-moulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to use cached, more recent tips suggest it over delegated.

@jd-moulton jd-moulton merged commit 8e5ec04 into master Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants