Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-artifact GHA to v4 #354

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Nov 8, 2024

Issue #, if available: n/a

Description of changes:
Version 1 and 2 of the upload-artifact, and download-artifact GHAs have been deprecated. This PR updates the actions used for ion-test-driver's report uploads to version 4.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 8, 2024

Failure of MacOS gcc build and test is due to gcc-11 being removed in latest macos runner images, and is addressed in #353.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 8, 2024

Appears that the branch name for ion-tests changed.. which is what is causing ion-test-driver to fail. Added a commit here to force it in the ion-c workflow, but I'll follow up with a PR to ion-test-driver to default to main instead of master.

@nirosys nirosys marked this pull request as ready for review November 8, 2024 10:45
@nirosys nirosys merged commit 91c5e50 into amazon-ion:master Nov 8, 2024
12 of 13 checks passed
@nirosys nirosys deleted the rgiliam/update_gha branch January 10, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants