Add Type Check to Strict Extractor #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarrowstone
force-pushed
the
strict-typing
branch
from
b6356a5 to
f6893e7
Compare
tgregg
approved these changes
Jan 8, 2025
| */ | ||
| public PathExtractorBuilder<T> withSearchPath(final List<PathComponent> pathComponents, | ||
| final BiFunction<IonReader, T, Integer> callback) { | ||
| return withSearchPath(pathComponents, callback, new String[0]); |
There was a problem hiding this comment.
We might as well use a constant for new String[0].
There was a problem hiding this comment.
This was actually a change from the other PR that I accidentally included here. I addressed it in that PR.
desaikd
approved these changes
Jan 8, 2025
| * The type check is performed _after_ any callbacks registered for the current path and | ||
| * _before_ any child matches are attempted. | ||
| */ | ||
| public PathExtractor<T> buildStrict(final boolean strictTyping) { |
There was a problem hiding this comment.
(Suggestion) Maybe we can make this private and have a buildStrictWithTypeCheck. It just sounds redundant to say PathExtractorBuilder.buildStrict(true).
There was a problem hiding this comment.
yea.. but it means that on the call-site I don't need to add branches if i already have a boolean flag.
Search paths on field names, indexed elements or wildcards imply an expectation for container types. Before this change, a search path looking for a field would simply not be invoked if the data was not a struct. With this change, users can elect to have an Exception thrown when data does not meet the implied type expectations of their paths. The type check is performed after any callback for the parent itself: that is not known to be mistyped by the paths. It is only implemented for the "strict" matcher and the change to the API reflects that.
rmarrowstone
force-pushed
the
strict-typing
branch
from
f6893e7 to
b6cebc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search paths on field names, indexed elements or wildcards imply an
expectation for container types. Before this change, a search path
looking for a field would simply not be invoked if the data was not
a struct. With this change, users can elect to have an Exception thrown
when data does not meet the implied type expectations of their paths.
The type check is performed after any callback for the parent itself:
that is not known to be mistyped by the paths.
It is only implemented for the "strict" matcher and the change to the
API reflects that.