-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple picocli/native-image ion-java CLI #988
Draft
jobarr-amzn
wants to merge
132
commits into
amazon-ion:ion-11-encoding
Choose a base branch
from
jobarr-amzn:simple-cli
base: ion-11-encoding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o address PR feedback.
…s more tests for numeric types.
…with inline text, blobs, and clobs.
…r before attempting to materialize them. (amazon-ion#985)
* Use add/set_macros/symbols in ManagedWriter * Apply suggestions from code review Removing redundant checks Co-authored-by: Matthew Pope <[email protected]> * Remove obsoleted checks/comments --------- Co-authored-by: Matthew Pope <[email protected]>
Ah oops, I built this locally with GraalVM CE 17 as described in the comments in build.gradle.kts. Looks like it will need more refinement of the build script to fix the build in other contexts- I want to only build the native component when GRAALVM_HOME is set. I can fix this... should probably extract to a separate Gradle project anyway. |
jobarr-amzn
force-pushed
the
simple-cli
branch
from
November 8, 2024 20:57
d1bcef1
to
0517913
Compare
* Test TDL reference to pre-existing macros * Support reference of pre-existing macros in TDL - Adds a DEFAULT Encoding context - Adds a MacroTable abstraction * PR suggestions * Comment asking for more modeling attention in MutableMacroTable
jobarr-amzn
force-pushed
the
simple-cli
branch
from
November 19, 2024 01:23
0517913
to
503ea51
Compare
…th ion-java-benchmark-cli.
…es minor cleanups.
…using specified macros and text patterns.
…rt for creating macro-aware readers from InputStream, and improves testing.
…instead of using symbol identifiers.
* Simplify ion-java-cli OutputFormat * Clarify unreachable statement message * Private static factories instead of functions
jobarr-amzn
force-pushed
the
simple-cli
branch
from
December 12, 2024 20:05
503ea51
to
43404df
Compare
* Restack macros and symbols to meet spec changes * Update ion-tests for symbol and macro restack * Fix comment in src/test/java/com/amazon/ion/impl/bin/WriteBufferTest.java Co-authored-by: Tyler Gregg <[email protected]> --------- Co-authored-by: Tyler Gregg <[email protected]>
- Supports formatted transcription of input files or stdin to a destination file or stdout # Conflicts: # ion-java-cli/src/main/java/com/amazon/tools/cli/OutputFormat.java
jobarr-amzn
force-pushed
the
simple-cli
branch
from
December 12, 2024 21:28
43404df
to
7c73766
Compare
tgregg
force-pushed
the
ion-11-encoding
branch
from
December 13, 2024 00:09
4f594cf
to
620228b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Supports formatted transcription of input files or stdin to a destination file or stdout.
help
showing subcommandshelp cat
showing inherited optionsRewriting Ion 1.1 with a macro invocation to Ion 1.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.