Adds integration testing for Ion 1.1 #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
zslayton
approved these changes
Oct 17, 2023
zslayton
approved these changes
Oct 19, 2023
Comment on lines
+152
to
+156
| fn read_embedded_doc_as_sequence(elem: &Element) -> IonResult<Sequence> { | ||
| match elem.value() { | ||
| Value::String(text) => Element::read_all(text.text().as_bytes()), | ||
| Value::Blob(bytes) => Element::read_all(bytes.as_ref()), | ||
| _ => panic!("Expected embedded document to be an Ion String or Ion Blob"), |
tests/element_test_vectors.rs
Outdated
| Self::read_group_embedded(&sequence, &group_assert)?; | ||
| } | ||
| (Value::List(group), false) | (Value::SExp(group), false) => { | ||
| match group_container.value().to_owned() { |
There was a problem hiding this comment.
Is the to_owned() needed? It looks like we're just iterating over whatever we get.
There was a problem hiding this comment.
A to_owned() is necessary somewhere because I can't have the if expression returning Sequence from one branch and &Sequence from another, but I was able to move the to_owned() call so that it is used as late as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
iontestdata->iontestdata_1_0.ion_1_1module toelement_test_vectors.rsintegration testing for the Ion 1.1 reader.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.