Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary 1.1 reader #737

Merged
merged 17 commits into from
Apr 16, 2024
Merged

Add support for binary 1.1 reader #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
189dfc3
Wire-up base 1.1 binary reader, and add null.null, and IVM support
nirosys Apr 4, 2024
8892925
Remove debug prints, and apply cargo fmt
nirosys Apr 5, 2024
83aeb0a
Fix value lengths
nirosys Apr 8, 2024
bfa5415
Add import; missed while branching for PRs
nirosys Apr 8, 2024
1964a2c
Fixed warnings; unused imports and such
nirosys Apr 9, 2024
f9402a6
Remove dead code
nirosys Apr 9, 2024
982504e
Removing more dead code
nirosys Apr 9, 2024
b31c2bc
Fix copy-pasta'd error; macros not yet implemented, not unsupported
nirosys Apr 9, 2024
b068d12
Remove changes to Never; ultimately unused
nirosys Apr 9, 2024
17aca97
Remove unneeded constants and fix is_null
nirosys Apr 9, 2024
4de4b0f
Address clippy checks
nirosys Apr 9, 2024
53406a7
Address rustdoc issues
nirosys Apr 9, 2024
83fa17e
Remove unneeded lifetime
nirosys Apr 9, 2024
41c67e2
Address PR feedback
nirosys Apr 11, 2024
ace4b53
Replace unimplemented macros with todo
nirosys Apr 11, 2024
cd885dd
Fix rust doc
nirosys Apr 11, 2024
09f3169
Apply suggestions from code review
nirosys Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/lazy_read_all_values.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ mod lazy_reader_example {

use memmap::MmapOptions;

use ion_rs::lazy::r#struct::LazyBinaryStruct;
use ion_rs::lazy::r#struct::LazyBinaryStruct_1_0 as LazyBinaryStruct;
use ion_rs::lazy::reader::LazyBinaryReader;
use ion_rs::lazy::value::LazyBinaryValue;
use ion_rs::lazy::value_ref::ValueRef;
Expand Down
5 changes: 5 additions & 0 deletions src/binary/constants.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ pub mod v1_0 {
pub const VAR_UINT: u8 = 14;
}
}

pub mod v1_1 {
/// Ion Version Marker byte sequence
pub const IVM: [u8; 4] = [0xE0, 0x01, 0x01, 0xEA];
}
Loading
Loading