Update CodeBuild Runner integration to include the run id and attempt #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
force-pushed
the
main
branch
3 times, most recently
from
94acfc5 to
0c8e6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
According to https://docs.aws.amazon.com/codebuild/latest/userguide/action-runner.html, we need to start including the run id and run attempt in the "runs on" configuration for CodeBuild-hosted runners.
This will also make it impossible to create a branch protection rule on those particular tasks because we don't have a stable job name now that the run id, etc. are now part of the strategy matrix and therefore part of the parameterized task name, so I've created a job that functions as a "join" operation for all of the build strategies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.