Update symbolTablesUnknownText.ion #85
Conversation
Updates the test to verify that imported with undefined text are not equivalent to: other imported symbols with undefined text and different SIds, local symbols with undefined text, or symbols with defined text. Before this change the differences in offset for the defined symbols alone was enough to cause it to pass.
| version: 1, | ||
| max_id: 2 } | ||
| ], | ||
| symbols:[ "foo", 31 ] |
There was a problem hiding this comment.
From https://amazon-ion.github.io/ion-docs/docs/symbols.html#local-symbol-tables
The
symbolsfield should be a list of strings. If the field is missing or has any other type, it is treated as if it were an empty list.Null elements in the symbols list declare unknown symbol text (“gaps”) for its SID within the sequence. Any element of the list that is not a string must be interpreted as if it were null. Any SIDs that refer to null slots in a local symbol table are equivalent to symbol zero.
What is this doing, why put a number here instead of an explicit null? Why 31?
There was a problem hiding this comment.
This could be any non-string (or null), testing the case where"Any element of the list that is not a string must be interpreted as if it were null."
I'm sure we have tests elsewhere that ensure the implementation treats all non-strings as null slots.
| @@ -1,25 +1,50 @@ | |||
| // import declaration, with max_id > 0 | |||
| // verifies that imported symbols with undefined text are not equivalent to: | |||
| // - other imported symbols with undefined text with different SIds | |||
There was a problem hiding this comment.
| // - other imported symbols with undefined text with different SIds | |
| // - other imported symbols with undefined text with different SIDs |
The symbols documentation generally says "SID"
Updates the test to verify that imported with undefined text are not equivalent to: other imported symbols with undefined text and different SIds, local symbols with undefined text, or symbols with defined text.
Before this change the differences in offset for the defined symbols alone was enough to cause it to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.