-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib(0.4.0): Use the version tag in links #85
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pages are generated with amber itself, amber-lang/amber#649 this PR it was used to do this other PR? |
Absolutely, yes. |
So it is better to merge the change in amber and after that his one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rerun amber docs --usage
with the latest version on staging
. Now that amber-lang/amber#653 has been merged, (i) the usage examples are not incomplete, and (ii) extra blank lines have been removed from the Markdown.
@hdwalters Done. But I have not verified the all newly added links are valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating 0.4.0 docs using 0.4.1 is not ideal. What should do?
* [fs_file_glob_absolute_missing_file.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_absolute_missing_file.ab) | ||
* [fs_file_glob_absolute_multiple_globs.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_absolute_multiple_globs.ab) | ||
* [fs_file_glob_absolute_wild_char.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_absolute_wild_char.ab) | ||
* [fs_file_glob_absolute_wild_star.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_absolute_wild_star.ab) | ||
* [fs_file_glob_absolute_with_spaces.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_absolute_with_spaces.ab) | ||
* [fs_file_glob_injection_attack.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_injection_attack.ab) | ||
* [fs_file_glob_relative_missing_file.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_relative_missing_file.ab) | ||
* [fs_file_glob_relative_multiple_globs.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_relative_multiple_globs.ab) | ||
* [fs_file_glob_relative_wild_char.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_relative_wild_char.ab) | ||
* [fs_file_glob_relative_wild_star.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_relative_wild_star.ab) | ||
* [fs_file_glob_relative_with_spaces.ab](https://github.com/amber-lang/amber/blob/0.4.0-alpha/src/tests/stdlib/fs_file_glob_relative_with_spaces.ab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links are 404
Ah, that's a good point, and this was never going to work. As I see it, we have two choices:
@Ph0enixKM, @Mte90, do you want to weigh in on this? |
No description provided.