feat: run trivy as image instead of downloading manually #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce complexity by using the official docker image as the CI job image instead of downloading by hand
|
I like it! Easier is better. My only remark is about the version: What do you think about putting the version into a variable, so it gets more visible? Or using latest as it has been before? |
|
Some flags can be replaced by using the https://aquasecurity.github.io/trivy/v0.22.0/getting-started/cli/config/ Example:
|
* Move severity to Environment variable * Add a few more comments * Always use the latest version of trivy
CleoArcher
suggested changes
Dec 11, 2023
Remove all references to docker
Remove last docker reference in variable
Alias old SEVERITY variable to TRIVY_SEVERITY for backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce complexity by using the official docker image as the CI job image instead of downloading by hand