Skip to content

Commit

Permalink
Version 5.0.0-beta.19
Browse files Browse the repository at this point in the history
  • Loading branch information
martynasma committed Sep 18, 2021
1 parent a6d3232 commit 6ba484c
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@amcharts/amcharts5",
"version": "5.0.0-beta.18",
"version": "5.0.0-beta.19",
"author": "amCharts <[email protected]> (https://www.amcharts.com/)",
"description": "amCharts 5",
"homepage": "https://www.amcharts.com/",
Expand Down
7 changes: 7 additions & 0 deletions packages/shared/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
Please note, that this project, while following numbering syntax, it DOES NOT
adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.

## [5.0.0-beta.19] - 2021-09-18

### Fixed
- Eemoving an axis from `xAxes` or `yAxes` was not working properly in some cases.
- If a `templateField` was set on some child of a bullet's `sprite`, it was being ignored.


## [5.0.0-beta.18] - 2021-09-17

### Added
Expand Down
8 changes: 3 additions & 5 deletions src/.internal/charts/hierarchy/LinkedHierarchy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,10 @@ export abstract class LinkedHierarchy extends Hierarchy {


/**
* Unlink two data items
* Unlink two linked data items.
*
* @param source Source node data item
* @param target Target node data item
* @param strength Link strength
* @return Link element
* @param source Source node data item
* @param target Target node data item
*/
public unlinkDataItems(source: DataItem<this["_dataItemSettings"]>, target: DataItem<this["_dataItemSettings"]>) {

Expand Down
2 changes: 1 addition & 1 deletion src/.internal/charts/xy/XYChart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ export class XYChart extends SerialChart {
if (axis) {
const axisParent = axis.parent
if (axisParent) {
axisParent.children.removeIndex(change.index);
axisParent.children.removeValue(axis);
}

const gridContainer = axis.gridContainer;
Expand Down
7 changes: 7 additions & 0 deletions src/.internal/core/render/Container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,13 @@ export class Container extends Sprite {
}
}

public _processTemplateField(): void {
super._processTemplateField();
this.children.each((child)=>{
child._processTemplateField();
})
}

/**
* @ignore
*/
Expand Down
2 changes: 1 addition & 1 deletion src/.internal/core/render/Sprite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ export abstract class Sprite extends Entity {
return new SpriteEventDispatcher(this);
}

protected _processTemplateField(): void {
public _processTemplateField(): void {
let template;

const field = this.get("templateField");
Expand Down

0 comments on commit 6ba484c

Please sign in to comment.