Version 5.4.9

package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "@amcharts/amcharts5",
-  "version": "5.4.8",
+  "version": "5.4.9",
   "author": "amCharts <[email protected]> (https://www.amcharts.com/)",
   "description": "amCharts 5",
   "homepage": "https://www.amcharts.com/",

packages/shared/CHANGELOG.md

@@ -5,6 +5,18 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 Please note, that this project, while following numbering syntax, it DOES NOT
 adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.
 
+## [5.4.9] - 2023-10-06
+
+### Added
+- `drawingsInteractive(value: bool)` method added to `StockChart`. `false` will make current annotations (drawings) to be fully static (non-editable).
+
+### Fixed
+- Zoom out button on `XYChart` was not focusable.
+- Pulled out slices of a `PieSeries` could overlap with other slices if some slices were hidden.
+- Pinch-zooming was not working properly in `XYChart`.
+- Candlesticks on a `StockChart` were being colored based on previous period close value instead of current period open value.
+
+
 ## [5.4.8] - 2023-09-22
 
 ### Added

src/.internal/charts/stock/StockChart.ts

@@ -9,6 +9,7 @@ import type { XYSeries, IXYSeriesDataItem, IXYSeriesSettings } from "../xy/serie
 import type { DataItem } from "../../core/render/Component";
 import type { Indicator } from "./indicators/Indicator";
 import type { DrawingSeries } from "./drawing/DrawingSeries";
+import type { SimpleLineSeries } from "./drawing/SimpleLineSeries";
 import { MultiDisposer } from "../../core/util/Disposer";
 
 import { PanelControls } from "./PanelControls";
@@ -142,7 +143,7 @@ export interface IStockChartEvents extends IContainerEvents {
 	drawingsupdated: {};
 
 	/**
-	 * Kicks in when drawings change.
+	 * Kicks in when indicators change.
 	 */
 	indicatorsupdated: {};
 }
@@ -280,16 +281,62 @@ export class StockChart extends Container {
 		}
 	}
 
+	/**
+	 * Forces redrawing of all annotations (drfawings).
+	 */
 	public markDirtyDrawings() {
 		this._drawingsChanged = true;
 		this.markDirty();
 	}
 
+	/**
+	 * Forces redrawing of Indicators.
+	 */
 	public markDirtyIndicators() {
 		this._indicatorsChanged = true;
 		this.markDirty();
 	}
 
+	/**
+	 * Enables or disables interactivity of annotations (drawings).
+	 * 
+	 * @param value Drawings interactive?
+	 * @since 5.4.9
+	 */
+	public drawingsInteractive(value: boolean) {
+		this.panels.each((panel) => {
+			panel.series.each((series) => {
+				if (series.isType<DrawingSeries>("DrawingSeries")) {
+					series.strokes.each((stroke) => {
+						stroke.set("interactive", value)
+					});
+
+					series.fills.each((fill) => {
+						fill.set("interactive", value)
+					});
+
+					$array.each(series.dataItems, (dataItem) => {
+						if (dataItem.bullets) {
+							const bullet = dataItem.bullets[0];
+							if (bullet) {
+								const sprite = bullet.get("sprite");
+								if (sprite) {
+									sprite.set("interactive", value);
+								}
+							}
+						}
+					})
+
+					if (series.isType<SimpleLineSeries>("SimpleLineSeries")) {
+						series.hitLines.each((hitLine) => {
+							hitLine.set("interactive", value)
+						})
+					}
+				}
+			})
+		})
+	}
+
 	public _prepareChildren() {
 
 		if (this.isDirty("volumeNegativeColor") || this.isDirty("volumePositiveColor")) {
@@ -303,7 +350,6 @@ export class StockChart extends Container {
 
 		const stockSeries = this.get("stockSeries");
 
-
 		if (this.isDirty("stockSeries")) {
 			if (stockSeries) {
 				this.indicators.each((indicator) => {
@@ -391,8 +437,8 @@ export class StockChart extends Container {
 				const stockNegativeColor = this.get("stockNegativeColor", this._root.interfaceColors.get("negative"));
 				const stockPositiveColor = this.get("stockPositiveColor", this._root.interfaceColors.get("positive"));
 				let previous = stockSeries.dataItems[0];
-				
-				if(stockPositiveColor && stockPositiveColor){
+
+				if (stockPositiveColor && stockPositiveColor) {
 					$array.each(stockSeries.dataItems, (dataItem) => {
 						const column = dataItem.get("graphics");
 						if (column) {
@@ -421,11 +467,27 @@ export class StockChart extends Container {
 						}
 					})
 
-					stockSeries.columns.template.states.create("riseFromOpen", { fill: stockPositiveColor, stroke: stockPositiveColor });
-					stockSeries.columns.template.states.create("riseFromPrevious", { fill: stockPositiveColor, stroke: stockPositiveColor });
+					const states = stockSeries.columns.template.states;
 
-					stockSeries.columns.template.states.create("dropFromOpen", { fill: stockNegativeColor, stroke: stockNegativeColor });
-					stockSeries.columns.template.states.create("dropFromPrevious", { fill: stockNegativeColor, stroke: stockNegativeColor });
+					const riseFromOpen = states.lookup("riseFromOpen");
+					if (riseFromOpen) {
+						riseFromOpen.setAll({ fill: stockPositiveColor, stroke: stockPositiveColor });
+					}
+
+					const riseFromPrevious = states.lookup("riseFromPrevious");
+					if (riseFromPrevious) {
+						riseFromPrevious.setAll({ fill: stockPositiveColor, stroke: stockPositiveColor });
+					}
+
+					const dropFromOpen = states.lookup("dropFromOpen");
+					if (dropFromOpen) {
+						dropFromOpen.setAll({ fill: stockNegativeColor, stroke: stockNegativeColor });
+					}
+
+					const dropFromPrevious = states.lookup("dropFromPrevious");
+					if (dropFromPrevious) {
+						dropFromPrevious.setAll({ fill: stockNegativeColor, stroke: stockNegativeColor });
+					}
 				}
 
 				stockSeries.markDirtyValues();
@@ -453,7 +515,7 @@ export class StockChart extends Container {
 			const yAxis = stockSeries.get("yAxis") as ValueAxis<AxisRenderer>;
 			yAxis.set("logarithmic", false);
 
-		
+
 			this._maybePrepAxisDefaults();
 			if (mainChart) {
 				const seriesList: XYSeries[] = [];
@@ -538,7 +600,7 @@ export class StockChart extends Container {
 				}
 			}
 
-			if (this.get("autoSetPercentScale")) {				
+			if (this.get("autoSetPercentScale")) {
 				this.setPercentScale(true);
 			}
 
@@ -865,7 +927,7 @@ export class StockChart extends Container {
 			}
 
 
-			if(negativeColor && positiveColor){
+			if (negativeColor && positiveColor) {
 				if (stockSeries && volumeSeries) {
 					const index = volumeSeries.dataItems.indexOf(dataItem);
 					if (index > 0) {

src/.internal/charts/xy/XYChart.ts

@@ -851,7 +851,7 @@ export class XYChart extends SerialChart {
 		const plotContainer = this.plotContainer;
 
 		if (this.get("pinchZoomX") || this.get("pinchZoomY")) {
-			const touchEvent = event as any;
+			const touchEvent = event.originalEvent as any;
 			const pointerId = touchEvent.pointerId;
 
 			if (pointerId) {

src/.internal/charts/xy/axes/DateAxis.ts

@@ -226,10 +226,11 @@ export class DateAxis<R extends AxisRenderer> extends ValueAxis<R> {
 			}
 
 
-			if (this.isDirty("groupInterval")) {
+			if (this.isDirty("groupInterval")) {				
 				let groupInterval = this.get("groupInterval")!;
 				if (groupInterval) {
 					this.setRaw("groupIntervals", [groupInterval]);
+					this._handleRangeChange();					
 				}
 			}
 
@@ -533,6 +534,7 @@ export class DateAxis<R extends AxisRenderer> extends ValueAxis<R> {
 							series.setDataSet(newId);
 						}
 					})
+
 					this.markDirtyExtremes();
 
 					this._root.events.once("frameended", () => {

src/.internal/charts/xy/axes/ValueAxis.ts

@@ -1002,9 +1002,9 @@ export class ValueAxis<R extends AxisRenderer> extends Axis<R> {
 			}
 
 			if (selectionMin === selectionMax) {
+				this._getDelta(selectionMax);
 				selectionMin -= this._deltaMinMax;
 				selectionMax += this._deltaMinMax;
-
 				let minMaxStep2 = this._adjustMinMax(selectionMin, selectionMax, gridCount, strictMinMax);
 				selectionMin = minMaxStep2.min;
 				selectionMax = minMaxStep2.max;

src/.internal/core/Registry.ts

@@ -6,7 +6,7 @@ export class Registry {
 	/**
 	 * Currently running version of amCharts.
 	 */
-	readonly version: string = "5.4.8";
+	readonly version: string = "5.4.9";
 
 	/**
 	 * List of applied licenses.

src/.internal/core/render/Series.ts

@@ -728,7 +728,10 @@ export abstract class Series extends Component {
 		const bullets = dataItem.bullets;
 		if(bullets){
 			$array.each(bullets, (bullet)=>{
-				promises.push(bullet.get("sprite").show(duration));
+				const sprite = bullet.get("sprite");
+				if(sprite){
+					promises.push(sprite.show(duration));
+				}
 			})
 		}
 		await Promise.all(promises);
@@ -746,7 +749,10 @@ export abstract class Series extends Component {
 		const bullets = dataItem.bullets;
 		if(bullets){
 			$array.each(bullets, (bullet)=>{
-				promises.push(bullet.get("sprite").hide(duration));
+				const sprite = bullet.get("sprite");
+				if(sprite){					
+					promises.push(sprite.hide(duration));
+				}
 			})
 		}
 		await Promise.all(promises);

src/.internal/core/render/Slice.ts

@@ -126,7 +126,7 @@ export class Slice extends Graphics {
 	public _beforeChanged() {
 		super._beforeChanged();
 
-		if (this.isDirty("radius") || this.isDirty("arc") || this.isDirty("innerRadius") || this.isDirty("startAngle") || this.isDirty("dRadius") || this.isDirty("dInnerRadius") || this.isDirty("cornerRadius")) {
+		if (this.isDirty("radius") || this.isDirty("arc") || this.isDirty("innerRadius") || this.isDirty("startAngle") || this.isDirty("dRadius") || this.isDirty("dInnerRadius") || this.isDirty("cornerRadius") || this.isDirty("shiftRadius")) {
 			this._clear = true;
 		}
 	}
@@ -168,12 +168,10 @@ export class Slice extends Graphics {
 
 			this.ix = $math.cos(middleAngle);
 			this.iy = $math.sin(middleAngle);
-		}
 
-		if (this.isDirty("shiftRadius")) {
 			const shiftRadius = this.get("shiftRadius", 0);
 			this.setRaw("dx", this.ix * shiftRadius);
-			this.setRaw("dy", this.iy * shiftRadius);
+			this.setRaw("dy", this.iy * shiftRadius);			
 			this.markDirtyPosition();
 		}
 	}

src/.internal/core/render/Sprite.ts

@@ -56,6 +56,18 @@ class SpriteEventDispatcher<Target, E extends Events<Target, ISpriteEvents>> ext
 		},
 
 		"pointerover": function(event) {
+			/*
+			const sprite = this._sprite;
+			let dispatch = true;
+			
+			if (sprite.get("isMeasured")) {
+				const bounds = sprite.globalBounds();
+				if (!$math.inBounds(event.point, bounds)) {
+					dispatch = false;
+					sprite._root._renderer.removeHovering(sprite._display);
+				}
+			}
+			*/
 			if (this.isEnabled("pointerover")) {
 				this.dispatch("pointerover", this._makePointerEvent("pointerover", event));
 			}
@@ -1153,6 +1165,9 @@ export abstract class Sprite extends Entity {
 
 		if (this.isDirty("opacity")) {
 			display.alpha = Math.max(0, this.get("opacity", 1));
+			if (this.get("focusable")) {
+				this.markDirtyAccessibility();
+			}
 		}
 
 		if (this.isDirty("rotation")) {