Allow js views #139
Allow js views #139
Conversation
Conflicts: Gemfile.lock
| @@ -4,7 +4,7 @@ class Property | |||
| attr_accessor :name | |||
| attr_reader :class_name, :default | |||
|
|
|||
| CANT_CLONE = [NilClass, TrueClass, FalseClass, Fixnum].freeze | |||
| CANT_CLONE = [NilClass, TrueClass, FalseClass, Integer].freeze | |||
There was a problem hiding this comment.
I would argue that you should still use fixnum
> 1.frozen?
=> true
[2] pry(main)> 1.5.frozen?
=> trueThere was a problem hiding this comment.
> 1.5.clone
TypeError: can't clone FloatThere was a problem hiding this comment.
well it actually looks like Float is not a fixnum, so that should be added too
There was a problem hiding this comment.
Fixnum is depracated in rails > 5.0 we need to remove it, and yeah we need to add float
I dont thing integer is needed
There was a problem hiding this comment.
does this change in rails 5?
> 1.clone
TypeError: can't clone FixnumThere was a problem hiding this comment.
yeah it change > 1.clone works on rails 5 with no error... I dont think this particular change affect us that much we can handle it and make it backwards compatible
There was a problem hiding this comment.
This change does affect us a lot. any default property that is an integer or a float would be affected
There was a problem hiding this comment.
this code is important for default properties to work
There was a problem hiding this comment.
And you don't think we can handle it in a way is compatible in both Tails 4 and 5?
There was a problem hiding this comment.
if there is a change to the inheritance models of the underlying rails/ruby code, I dont think so. Feel free to prove me wrong. I feel like this is a change that will not be compatable with rails 4 if Fixnum does not exist
Allow to create JS only views