Fixing formatting on enum value names

americanexpress · Mar 11, 2016 · 5ca6891 · 5ca6891
1 parent a26130e
commit 5ca6891
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/bucketlist/src/main/kotlin/io/aexp/bucketlist/HttpBucketListClient.kt b/bucketlist/src/main/kotlin/io/aexp/bucketlist/HttpBucketListClient.kt
@@ -105,15 +105,15 @@ class HttpBucketListClient(private val baseUrl: URL,
 
     private fun getDiffAPICommentModeValue(commentMode: CommentMode): String {
         when(commentMode) {
-            CommentMode.WithComments -> return "true"
-            CommentMode.WithoutComments -> return "false"
+            CommentMode.WITH_COMMENTS -> return "true"
+            CommentMode.WITHOUT_COMMENTS -> return "false"
         }
     }
 
     private fun getDiffAPIWhitespaceModeValue(whitespaceMode: WhitespaceMode): String {
         when(whitespaceMode) {
-            WhitespaceMode.Show -> return "show"
-            WhitespaceMode.IgnoreAll -> return "ignore-all"
+            WhitespaceMode.SHOW -> return "show"
+            WhitespaceMode.IGNORE_ALL -> return "ignore-all"
         }
     }
 

diff --git a/bucketlist/src/main/kotlin/io/aexp/bucketlist/WhitespaceMode.kt b/bucketlist/src/main/kotlin/io/aexp/bucketlist/WhitespaceMode.kt
@@ -2,8 +2,8 @@ package io.aexp.bucketlist
 
 
 enum class WhitespaceMode {
-    Show,
-    IgnoreAll
+    SHOW,
+    IGNORE_ALL
 }
 
 
diff --git a/bucketlist/src/main/kotlin/io/aexp/bucketlist/data/CommentMode.kt b/bucketlist/src/main/kotlin/io/aexp/bucketlist/data/CommentMode.kt
@@ -2,6 +2,6 @@ package io.aexp.bucketlist.data
 
 
 enum class CommentMode {
-    WithComments,
-    WithoutComments
+    WITH_COMMENTS,
+    WITHOUT_COMMENTS
 }
diff --git a/bucketlist/src/test/java/io/aexp/bucketlist/HttpBucketListClientTest.java b/bucketlist/src/test/java/io/aexp/bucketlist/HttpBucketListClientTest.java
@@ -196,7 +196,7 @@ public void testGetPrDiff() throws IOException {
                 giveResponse(Resources.toString(getResource(getClass(), "getPrDiffResp.json"), UTF_8),
                         "application/json"));
 
-        PullRequestDiffResponse diffResponse = client.getPrDiff(proj, repo, 2, 0, WhitespaceMode.IgnoreAll, CommentMode.WithoutComments)
+        PullRequestDiffResponse diffResponse = client.getPrDiff(proj, repo, 2, 0, WhitespaceMode.IGNORE_ALL, CommentMode.WITHOUT_COMMENTS)
                 .toBlocking()
                 .first();
 

diff --git a/.../main/kotlin/io/aexp/bucketlist/examples/prfileoccurrences/ExportPrFileOccurrencesData.kt b/.../main/kotlin/io/aexp/bucketlist/examples/prfileoccurrences/ExportPrFileOccurrencesData.kt
@@ -97,7 +97,7 @@ object ExportPrFileOccurrencesData {
             Observable<String> {
         logger.debug("Fetching diff for PR " + prId);
 
-        return client.getPrDiff(projectKey, repoSlug, prId, 0, WhitespaceMode.IgnoreAll, CommentMode.WithoutComments)
+        return client.getPrDiff(projectKey, repoSlug, prId, 0, WhitespaceMode.IGNORE_ALL, CommentMode.WITHOUT_COMMENTS)
                 .flatMap { diffResponse ->
                     logger.debug("Parsing PR for files changed");
                     // Filter diffs with Null sources or destinations as that indicates a new or deleted file. Then