fixes on undefined system

ametel01 · Jan 2, 2024 · c9ee099 · c9ee099
1 parent 7806a15
commit c9ee099
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/testnet/frontend/src/hooks/usePlanetPosition.ts b/packages/testnet/frontend/src/hooks/usePlanetPosition.ts
@@ -3,7 +3,7 @@ import { GAMEADDRESS } from '../constants/addresses';
 import gameContract from '../constants/nogame.json';
 import { type Position } from '../shared/types';
 
-const DefaultPosition = {
+export const DefaultPosition: Position = {
   system: 0,
   orbit: 0,
 };
@@ -22,5 +22,5 @@ export function usePlanetPosition(planetId: number | undefined) {
     return DefaultPosition;
   }
 
-  return data as unknown as Position;
+  return data as Position;
 }
diff --git a/packages/testnet/frontend/src/shared/utils/index.ts b/packages/testnet/frontend/src/shared/utils/index.ts
@@ -1,6 +1,7 @@
 /* eslint-disable no-unused-vars */
 import BigNumber from 'bignumber.js';
 import { type Position, type TechLevels } from '../types';
+import { DefaultPosition } from '../../hooks/usePlanetPosition';
 
 export const dataToNumber = (value: unknown[] | string | number | undefined) =>
   new BigNumber(value as unknown as number).toNumber();
@@ -261,7 +262,12 @@ export function convertTechLevelsToNumbers(techLevels: TechLevels): {
   return converted;
 }
 
-export function convertPositionToNumbers(position: Position): Position {
+export function convertPositionToNumbers(
+  position?: Position
+): Position | undefined {
+  if (!position) {
+    return DefaultPosition;
+  }
   return {
     system: Number(position.system),
     orbit: Number(position.orbit),