Revert "gc just to be safe prior to run loop exit"

This reverts commit ad48318.
amphp · Aug 8, 2015 · 6612bb8 · 6612bb8
1 parent a806161
commit 6612bb8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/lib/EvReactor.php b/lib/EvReactor.php
@@ -111,8 +111,6 @@ public function run(callable $onStart = null) {
             $this->loop->run($flags);
         }
 
-        \gc_collect_cycles();
-
         $this->state = self::STOPPED;
         if ($this->stopException) {
             $e = $this->stopException;

diff --git a/lib/LibeventReactor.php b/lib/LibeventReactor.php
@@ -92,8 +92,6 @@ public function run(callable $onStart = null) {
             \event_base_loop($this->keepAliveBase, $flags);
         }
 
-        \gc_collect_cycles();
-
         $this->state = self::STOPPED;
         if ($this->stopException) {
             $e = $this->stopException;

diff --git a/lib/NativeReactor.php b/lib/NativeReactor.php
@@ -73,8 +73,6 @@ public function run(callable $onStart = null) {
             }
         }
 
-        \gc_collect_cycles();
-
         $this->timersEnabled = false;
         $this->state = self::STOPPED;
     }

diff --git a/lib/UvReactor.php b/lib/UvReactor.php
@@ -93,8 +93,6 @@ public function run(callable $onStart = null) {
             \uv_run($this->loop, \UV::RUN_DEFAULT | (empty($this->immediates) ? \UV::RUN_ONCE : \UV::RUN_NOWAIT));
         }
 
-        \gc_collect_cycles();
-
         $this->state = self::STOPPED;
         if ($this->stopException) {
             $e = $this->stopException;
@@ -136,7 +134,7 @@ public function tick($noWait = false) {
                 "Cannot tick() recursively; event reactor already active"
             );
         }
-
+        
         $this->state = self::TICKING;
 
         $noWait = (bool) $noWait;
@@ -146,7 +144,7 @@ public function tick($noWait = false) {
                 break;
             }
         }
-
+        
         // Check the conditional again because a manual stop() could've changed the state
         if ($this->state) {
             $flags = $noWait || !empty($this->immediates) ? (\UV::RUN_NOWAIT | \UV::RUN_ONCE) : \UV::RUN_ONCE;
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,8 +73,6 @@ public function run(callable $onStart = null) { @@
                 }
             }
-            \gc_collect_cycles();
             $this->timersEnabled = false;
             $this->state = self::STOPPED;
         }
@@ Expand Down @@