Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Amp 90349 plugins not receiving session id #636

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: Amp 90349 plugins not receiving session id #636

merged 1 commit into from
Dec 19, 2023

Conversation

justin-fiedler
Copy link
Contributor

Summary

  • Plugins were not receiving the config.sessionId
  • Made it so browser config is finalized before calling plugin.setup

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@justin-fiedler justin-fiedler marked this pull request as ready for review December 18, 2023 17:21
@justin-fiedler justin-fiedler requested a review from a team December 18, 2023 17:45
jxiwang
jxiwang approved these changes Dec 18, 2023
View reviewed changes
Copy link

@jxiwang jxiwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justin-fiedler justin-fiedler merged commit b84e184 into v1.x Dec 19, 2023
3 checks passed
@justin-fiedler justin-fiedler deleted the AMP-90349-mobile-sr-browser-sr-plugin-not-receiving-session-id-device-id-from-sdk-in-puppeteer-env branch December 19, 2023 14:25
justin-fiedler added a commit that referenced this pull request Dec 20, 2023
@justin-fiedler
fix: revert pr #636 which shift sessionid logic
b763eb2
@justin-fiedler justin-fiedler mentioned this pull request Dec 20, 2023
Merged
1 task
justin-fiedler added a commit that referenced this pull request Dec 20, 2023
@justin-fiedler
fix: revert pr #636 which shift sessionid logic
58f58ce
justin-fiedler added a commit that referenced this pull request Dec 20, 2023
@justin-fiedler
fix: revert pr #636 which shift sessionid logic
7337ba5
justin-fiedler added a commit that referenced this pull request Dec 20, 2023
@justin-fiedler
revert: Amp 90349 revert session id insert before plugin setup (#639)
0d03e9c 
* fix: revert pr #636 which shift sessionid logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

@jxiwang jxiwang jxiwang approved these changes

@kevinpagtakhan kevinpagtakhan Awaiting requested review from kevinpagtakhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justin-fiedler @qingzhuozhen @jxiwang