You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I did work on refactoring the CLI commands, one of the initial steps was to make all internal methods private, so that the commands could act as command classes on their own.
Later, I noticed that the tests were built in such a way to require all internals to be public. So instead of rewriting all the tests, I opened another issue to introduce an abstraction layer (#3077) to remed this problem and come back to later. To make the tests pass for the build, I made the internals public again.
However, now, because of the changed command structure, all of the internal methods are exposed as subcommands because of this:
The text was updated successfully, but these errors were encountered:
When I did work on refactoring the CLI commands, one of the initial steps was to make all internal methods private, so that the commands could act as command classes on their own.
Later, I noticed that the tests were built in such a way to require all internals to be public. So instead of rewriting all the tests, I opened another issue to introduce an abstraction layer (#3077) to remed this problem and come back to later. To make the tests pass for the build, I made the internals public again.
However, now, because of the changed command structure, all of the internal methods are exposed as subcommands because of this:
![Image 2019-08-27 at 5 24 39 PM](https://user-images.githubusercontent.com/83631/63785016-eec2e600-c8ef-11e9-9f92-453d869f83bd.png)
The text was updated successfully, but these errors were encountered: