Make internal methods inaccessible #3229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP-CLI exposes every public method it encounters in a command object as a new subcommand. Therefore we make the internal methods private again.
As this breaks the current tests, we add a helper function in the tests to invoke these private methods as if they were public. This is a short-term fix for now.
The cleaner long-term solution would be to work on #3077 and get all actual business logic out of the commands. When the commands do nothing more than parsing arguments and formatting outputs, these unit tests become unnecessary here.
Before
After
Fixes #3102