Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI configuration #2810

Merged
merged 8 commits into from
Jul 15, 2019
Merged

Improve CI configuration #2810

merged 8 commits into from
Jul 15, 2019

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Jul 15, 2019

  • Fix definition of global env variable
  • Remove incorrect docker volumes
  • Stop local environment after running e2e tests
  • Add demo plugin that demonstrates how plugins can be used during e2e tests
  • Add new CI step to run e2e tests as author

Related: #2795.

@swissspidy swissspidy added Enhancement New feature or improvement of an existing one Infrastructure Changes impacting testing infrastructure or build tooling labels Jul 15, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Jul 15, 2019
@swissspidy swissspidy requested review from westonruter and miina July 15, 2019 14:03
@westonruter
Copy link
Member

Why is the demo plugin needed here?

@swissspidy
Copy link
Collaborator Author

@westonruter It basically acts as documentation to show how adding plugins for E2E tests works.

Alternatively we can just wait until we actually need some of these plugins when adding the first bunch of tests.

@westonruter
Copy link
Member

I'm confused though: these tests are for the AMP plugin. Why would adding plugins need to be tested in this project?

@westonruter
Copy link
Member

Unless the intention is to test that AMP validation errors are getting properly attributed?

@swissspidy
Copy link
Collaborator Author

@westonruter It's not about testing plugins. This change allows for adding some utility plugins that can be activated during E2E tests.

For example, such a plugin could create a custom post type and the accompanying E2E test would verify that block validation errors are shown for this custom post type too.

@swissspidy swissspidy merged commit c02b046 into develop Jul 15, 2019
@swissspidy swissspidy deleted the update/ci-config branch July 15, 2019 18:57
@westonruter westonruter added this to the v1.2.1 milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA Enhancement New feature or improvement of an existing one Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants