Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for empty dependencies on admin bar style loader tag filter #7920

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

refactor similar functions & test

5f17b90
Select commit
Loading
Failed to load commit list.
Open

Fix check for empty dependencies on admin bar style loader tag filter #7920

refactor similar functions & test
5f17b90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 1s

77.69% (+12.39%) compared to d101379

View this Pull Request on Codecov

77.69% (+12.39%) compared to d101379

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.69%. Comparing base (d101379) to head (5f17b90).

Files with missing lines Patch % Lines
includes/class-amp-theme-support.php 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #7920       +/-   ##
==============================================
+ Coverage      65.29%   77.69%   +12.39%     
- Complexity         0     6569     +6569     
==============================================
  Files             68      204      +136     
  Lines           1219    21163    +19944     
==============================================
+ Hits             796    16443    +15647     
- Misses           423     4720     +4297     
Files with missing lines Coverage Δ
includes/class-amp-theme-support.php 87.25% <66.66%> (ø)

... and 271 files with indirect coverage changes