Fix: #730 and #733 - Unable to build/install under Python 3.12 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon 3.12 1. Replaced deprecated names based on Python 3.12's changelog (configparser.SafeConfigParser -> configparser.ConfigParser, configparser.readfp() -> configparser.read_file()). 2. Added Cython as a dependency. 3. Changed the generation of the Cython C code for release to occur and compile during setup.py execution.
|
I would love to see this merged! |
macserv
reviewed
Oct 31, 2023
setup.py
Outdated
| @@ -3,6 +3,8 @@ | |||
| from setuptools.extension import Extension | |||
thomasjpfan
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thank you for the PR @T1t4m1un ! I updated the PR to include 3.12 in the tests.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #733 :
Replaced deprecated names based on Python 3.12's changelog (configparser.SafeConfigParser -> configparser.ConfigParser, configparser.readfp() -> configparser.read_file()). These two both have been introduced into lib before python 3,5, barely not introduce the risk of front-compatibility.
FIX #730 :
After I fix the problem introduced by deprecated module and method, new problem that GCC cannot compile the cython C code. I found the pre-generated code is under a fairly old version of cython, which generation raising many warnings while compiling.