Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose conformance to CredentialsProviderV2. #40

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Expose conformance to CredentialsProviderV2. #40

merged 1 commit into from
Dec 19, 2023

Conversation

tachyonics
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Expose conformance to CredentialsProviderV2, allowing this protocol to be used without a type cast.
  2. Provide more descriptive logging including the expiry date of the current credentials and consistently use the decorated logger passed into AwsRotatingCredentialsProviderV2 (this was always decorated with the credentials.source metadata and so doesn't need roleSessionName which provides the same information)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tachyonics tachyonics requested a review from a user December 18, 2023 09:02
@tachyonics tachyonics merged commit 05bf549 into main Dec 19, 2023
7 checks passed
@tachyonics tachyonics deleted the expose_v2_conformance branch December 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knovichikhin knovichikhin knovichikhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tachyonics @knovichikhin