-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anaconda Distribution and Miniconda installer preset #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have one suggestion: I think it would be beneficial to name the files:
- docs/anaconda-installers.md
- anaconda-installers.json
and also change the reference in the doc in L11 to make sure these files are about our anaconda installers and not some other (generic) installers. For users this might make it easier to understand what installer
is meant here, especially in our generic renovate-config repository which is used for different kinds of things.
…g into installer-preset
Good idea! It's always better to be more explicit |
Description/Purpose
Anaconda Distribution and Miniconda installers undergo a different release process than other dependencies that can be found on, e.g., GitHub or PyPi. Consequently, a custom-built renovate data source is needed to capture these installers.
This PR provides custom data sources and package rules for both Anaconda Distribution and Miniconda installers. Additionally, documentation is provided to show users how to incorporate this preset and to explain the complex transformation templates for this preset.
Expected Impact
Developers will be able to keep dependencies on Anaconda Distribution and Miniconda installers up-to-date using renovate. The default renovate managers are currently not capable of accomplishing this.
Multiple installers architectures in one repository are bundled into one pull request. However, Anaconda Distribution and Miniconda will be split.
Changes
Dockerfile
documentation: the regex manager has been removed fromdefaults.json
and the use case is misleading since Miniconda installers are not available whenconda
is published on GitHub.