Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaconda Distribution and Miniconda installer preset #83

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

marcoesters
Copy link
Contributor

Description/Purpose

Anaconda Distribution and Miniconda installers undergo a different release process than other dependencies that can be found on, e.g., GitHub or PyPi. Consequently, a custom-built renovate data source is needed to capture these installers.

This PR provides custom data sources and package rules for both Anaconda Distribution and Miniconda installers. Additionally, documentation is provided to show users how to incorporate this preset and to explain the complex transformation templates for this preset.

Expected Impact

Developers will be able to keep dependencies on Anaconda Distribution and Miniconda installers up-to-date using renovate. The default renovate managers are currently not capable of accomplishing this.

Multiple installers architectures in one repository are bundled into one pull request. However, Anaconda Distribution and Miniconda will be split.

Changes

  • Add a preset for Anaconda Distribution and Miniconda installers
  • Add documentation describing how to use the preset and explaining the transformation template
  • Remove Dockerfile documentation: the regex manager has been removed from defaults.json and the use case is misleading since Miniconda installers are not available when conda is published on GitHub.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@marcoesters marcoesters marked this pull request as ready for review April 12, 2024 22:06
@marcoesters marcoesters requested review from a team, stefanandres and ximena9201 April 12, 2024 22:06
@marcoesters marcoesters changed the title Installer preset Anaconda Distribution and MIniconda installer preset Apr 12, 2024
Copy link
Contributor

@stefanandres stefanandres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have one suggestion: I think it would be beneficial to name the files:

  • docs/anaconda-installers.md
  • anaconda-installers.json

and also change the reference in the doc in L11 to make sure these files are about our anaconda installers and not some other (generic) installers. For users this might make it easier to understand what installer is meant here, especially in our generic renovate-config repository which is used for different kinds of things.

@marcoesters
Copy link
Contributor Author

LGTM

I have one suggestion: I think it would be beneficial to name the files:

* docs/anaconda-installers.md

* anaconda-installers.json

and also change the reference in the doc in L11 to make sure these files are about our anaconda installers and not some other (generic) installers. For users this might make it easier to understand what installer is meant here, especially in our generic renovate-config repository which is used for different kinds of things.

Good idea! It's always better to be more explicit

@marcoesters marcoesters changed the title Anaconda Distribution and MIniconda installer preset Anaconda Distribution and Miniconda installer preset Apr 15, 2024
@stefanandres stefanandres merged commit c5b25e5 into main Apr 16, 2024
1 check passed
@stefanandres stefanandres deleted the installer-preset branch April 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants