Enable Docker digest pinning #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker container tags are not immutable versions, thus pinning them from e.g. node:14.15.1 to node:14.15.1@sha256:d938c1761e3afbae9242848ffbb95b9cc1cb0a24d889f8bd955204d347a7266e prevents "unnoticed" changes in containers. This is especially relevant to all the external containers we use in helm charts or FROM statements, as somebody could replace a known good version with a bad one (supply chain attack). The impact of the PR is from "FROM CONTAINER:$VERSION" statements in Dockerfiles to helm charts and values files. It requires to also to make certain tags more explicit like from "debian:12-slim" to "debian:12.5-slim", to not have the digest changed without a version change. This can be done incrementally via the PRs that renovate anyways opens. Renovate says "We recommend that you pin your Docker images to an exact digest". We can disable this any time globally or per repo / file, in case it is unwanted. See also: * https://docs.renovatebot.com/docker/#digest-pinning * https://docs.renovatebot.com/presets-docker/#dockerpindigests
morremeyer
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker container tags are not immutable versions, thus pinning them from e.g. node:14.15.1 to node:14.15.1@sha256:d938c1761e3afbae9242848ffbb95b9cc1cb0a24d889f8bd955204d347a7266e prevents "unnoticed" changes in containers.
This is especially relevant to all the external containers we use in helm charts or FROM statements, as somebody could replace a known good version with a bad one (supply chain attack).
The impact of the PR is from "FROM CONTAINER:$VERSION" statements in Dockerfiles to helm charts and values files.
It requires to also to make certain tags more explicit like from "debian:12-slim" to "debian:12.5-slim", to not have the digest changed without a version change. This can be done incrementally via the PRs that renovate anyways opens.
Renovate says "We recommend that you pin your Docker images to an exact digest". We can disable this any time globally or per repo / file, in case it is unwanted.
See also:
Description/Purpose
Expected Impact