-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ltc7871 #2402
base: main
Are you sure you want to change the base?
Add support for ltc7871 #2402
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
35762fe
to
a75c351
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
c5f7e3a
to
1849638
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
021ed00
to
d01e5b9
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
c8a969a
to
6eb93c2
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add initial header and source files for LTC7871 driver. Signed-off-by: Aldrin Abacan <[email protected]>
c799fa9
to
c8f58c7
Compare
Add initial header and source file for LTC7871 IIO driver. Signed-off-by: Aldrin Abacan <[email protected]>
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Add README.rst documentation file for LTC7871 alongside other documentation related files. Signed-off-by: Aldrin Abacan <[email protected]>
Add initial project files for both basic and IIO examples for LTC7871. Signed-off-by: Aldrin Abacan <[email protected]>
Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Aldrin Abacan <[email protected]>
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
if (!desc) | ||
return -ENODEV; | ||
|
||
no_os_free(desc->iio_dev->channels); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This array is statically allocated
pr_info("IDAC_Vlow: %duA\n", idac); | ||
} else { | ||
pr_info("Device on Boost mode\n"); | ||
//TODO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
#include "maxim_uart.h" | ||
#include "maxim_uart_stdio.h" | ||
|
||
#ifdef IIO_SUPPORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the ifdef is not needed, you may delete it
.. code-block:: bash | ||
|
||
# Select the example you want to enable by choosing y for enabling and n for disabling | ||
BASIC_EXAMPLE = y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update this, this is not true anymore
.. code-block:: bash | ||
|
||
# Select the example you want to enable by choosing y for enabling and n for disabling | ||
BASIC_EXAMPLE = n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
# to delete current build | ||
make PLATFORM=maxim TARGET=max32690 reset | ||
# to build the project and flash the code | ||
make PLATFORM=maxim TARGET=max32690 run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe split this in two, dont build and run on the same line, it works but may confuse readers
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist