AD9152.h Register Definition Updates #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosefKassai
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
|
this is good but make sure to squash the 2nd commit into the first, we use |
|
also, dont close the old PR, we're supposed to have the conversation in a single pull request this is a continuation of #2417 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Updated the register definitions (including additions, removals, and corrections) in AD9152.h to match Tables 16, 17, 18, 36, 73, and 85 of the datasheet. Signed-off-by: Josef Kassai <[email protected]>
JosefKassai
force-pushed
the
AD9152_Header_Updates
branch
from
1685aeb to
42862b3
Compare
buha
approved these changes
Jan 22, 2025
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
amiclaus
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register definitions in AD9152.h have been updated to match the datasheet - registers that aren't in the datasheet have been removed, and registers missing from the header file that were in the datasheet have been added. A few registers have also been renamed to match the datasheet.
PR Type
PR Checklist