-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate some projects to new example infrastructure #2420
Open
buha
wants to merge
8
commits into
main
Choose a base branch
from
staging/examples3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
requested review from
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
January 23, 2025 12:12
buha
force-pushed
the
staging/examples3
branch
from
January 23, 2025 14:23
79a2272
to
7fd64a7
Compare
buha
commented
Jan 23, 2025
struct no_os_irq_ctrl_desc *nvic_desc; | ||
struct no_os_irq_init_param nvic_ip = { | ||
.platform_ops = &max_irq_ops, | ||
}; | ||
struct no_os_gpio_desc *adxl355_gpio_desc; | ||
|
||
/* Initialize DATA READY pin */ | ||
ret = no_os_gpio_get_optional(&adxl355_gpio_desc, &adxl355_gpio_drdy_ip); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this DRDY pin is really weird, it's initialized for the iio_trigger_example (aducm3029 and maxim BUT NOT stm32!) but it's not used anywhere, so if anyone has an explanation for this let me know
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
force-pushed
the
staging/examples3
branch
from
January 27, 2025 09:01
7fd64a7
to
6a0c60c
Compare
Make the necessary changes to use the new example infrastructure. Signed-off-by: Darius Berghe <[email protected]>
buha
force-pushed
the
staging/examples3
branch
from
January 27, 2025 12:45
6a0c60c
to
52820bb
Compare
V2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates several projects to the new example infrastructure, most important being adxl355 which was used as template for many others.
PR Type
PR Checklist