Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161883256 clean up account activation class #44

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Edward-K1
Copy link
Contributor

@Edward-K1 Edward-K1 commented Nov 12, 2018

What does this PR do?

It removes the multiple return statements that were flagged by code climate in account activation view.

Description of Task to be completed?

  • Remove multiple return statements

How should this be manually tested?

By inspecting the VerifyAccountAPIView class in authors/apps/authentication/views.py

What are the relevant pivotal tracker stories?

#161883256

@Edward-K1 Edward-K1 changed the title #161883256 clean up duplicated code in account activation view #161883256 clean up multiple returns in account activation view Nov 12, 2018
@Edward-K1 Edward-K1 force-pushed the ch-cleanup-duplicate-code-161883256 branch 2 times, most recently from 3017972 to 3af02d8 Compare November 12, 2018 20:17
@Edward-K1 Edward-K1 changed the title #161883256 clean up multiple returns in account activation view #161883256 clean up account activation class Nov 12, 2018
@Edward-K1 Edward-K1 force-pushed the ch-cleanup-duplicate-code-161883256 branch from 3af02d8 to 7a1c17f Compare November 12, 2018 20:21
@Edward-K1 Edward-K1 force-pushed the ch-cleanup-duplicate-code-161883256 branch from 7a1c17f to 434fa91 Compare November 22, 2018 18:27
-remove multiple return statements

[Delivers #161883256]
@Edward-K1 Edward-K1 force-pushed the ch-cleanup-duplicate-code-161883256 branch from 434fa91 to d794995 Compare November 22, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant