Feature/api #1
Open
Feature/api #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladgasik
reviewed
Mar 11, 2022
|
|
||
| @admin.register(Place) | ||
| class PlaceAdmin(OSMGeoAdmin): | ||
| list_display = ('name', 'location', 'address', 'image', 'type') |
There was a problem hiding this comment.
Suggested change
| list_display = ('name', 'location', 'address', 'image', 'type') | |
| list_display = ('name', 'location', 'address', 'image', 'type', ) |
There was a problem hiding this comment.
Use black to evade '' and "" differences
Vladgasik
reviewed
Mar 14, 2022
|
|
||
| @admin.register(Rate) | ||
| class RateAdmin(admin.ModelAdmin): | ||
| list_display = ("rating", "created_at", "user", "comment") |
There was a problem hiding this comment.
Suggested change
| list_display = ("rating", "created_at", "user", "comment") | |
| list_display = ("rating", "created_at", "user", "comment", ) |
|
|
||
| @admin.register(Place) | ||
| class PlaceAdmin(OSMGeoAdmin): | ||
| list_display = ('name', 'location', 'address', 'image', 'type') |
There was a problem hiding this comment.
Use black to evade '' and "" differences
| name='type', | ||
| field=models.CharField(default='shop', max_length=200), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Man, 12 migrations... There is squash option
| path("ping", views.ping, name="index"), | ||
| path("places", PlaceListAPIView.as_view({"get": "list", "post": "create"}), name="place-list"), | ||
| path("places/<int:pk>/ratings", PlaceListAPIView.as_view({"post": "create_rating"}), name="comment-list"), | ||
| path("comments/<int:pk>/releted-comments", RelatedCommentAPIView.as_view({"post": "create_related_comment"}), name="related-comments") |
There was a problem hiding this comment.
Suggested change
| path("comments/<int:pk>/releted-comments", RelatedCommentAPIView.as_view({"post": "create_related_comment"}), name="related-comments") | |
| path("comments/<int:pk>/related-comments", RelatedCommentAPIView.as_view({"post": "create_related_comment"}), name="related-comments") |
|
|
||
|
|
||
| def validate_rating(value): | ||
| if value < 0 or value > 5: |
There was a problem hiding this comment.
Suggested change
| if value < 0 or value > 5: | |
| if not 0 <= value <= 5: |
|
|
||
| from django.contrib.gis.geos import Point | ||
| from entertainment.models import Place, Rate, Comment | ||
| from entertainment.serializers import PlaceSerializer, RateSerializer, CommentSerializer | ||
|
|
||
|
|
||
| @api_view(['GET']) | ||
| def ping(request): |
| @@ -78,7 +81,7 @@ | |||
|
|
|||
| DATABASES = { | |||
| 'default': { | |||
| 'ENGINE': 'django.db.backends.postgresql', | |||
| 'ENGINE': 'django.contrib.gis.db.backends.postgis', | |||
| 'NAME': os.environ['DATABASE'], | |||
| 'USER': "rating", | |||
| class UserSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = User | ||
| fields = ('username',) |
There was a problem hiding this comment.
there are many files without empty line at the end of file
|
|
||
| # Create your views here. | ||
| from .serializers import RegisterSerializer |
| ('location', django.contrib.gis.db.models.fields.PointField(srid=4326)), | ||
| ('address', models.CharField(max_length=255)), | ||
| ('image', models.ImageField(blank=True, null=True, upload_to='')), | ||
| ('type', models.CharField(choices=[('cafe', 'Cafe'), ('restaurant', 'Restaurant'), ('sport', 'Sport'), ('tech', 'tech'), ('shop', 'Shop')], default='cafe', max_length=20)), |
There was a problem hiding this comment.
Why max_length = 20, if longest choice is restaraunt which is 10 characters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.