Adds support for Exercise Goals #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garanj
approved these changes
Aug 21, 2024
...pleCompose/app/src/main/java/com/example/exercisesamplecompose/data/ExerciseClientManager.kt
Outdated
Show resolved
Hide resolved
...pleCompose/app/src/main/java/com/example/exercisesamplecompose/data/ExerciseClientManager.kt
Show resolved
Hide resolved
| icon = { Icon(Icons.Default.SportsScore, contentDescription = "goal achieved") }, | ||
| title = stringResource(id = R.string.goal_achieved), | ||
| showDialog = showDialog, | ||
| durationMillis = 10L, |
There was a problem hiding this comment.
10ms seems pretty short, does this show for long enough?
There was a problem hiding this comment.
Agreed. I'll update it to 50, and maybe look into some sort of vibration in a later iteration. Definitely want to modify the ExerciseGoalMet component more because 1) it isn't centered and 2) it could look nicer 😅
.../app/src/main/java/com/example/exercisesamplecompose/presentation/exercise/ExerciseScreen.kt
Outdated
Show resolved
Hide resolved
...pp/src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsScreen.kt
Outdated
Show resolved
Hide resolved
...pp/src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsScreen.kt
Outdated
Show resolved
Hide resolved
...pp/src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsScreen.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsViewModel.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
.../app/src/main/java/com/example/exercisesamplecompose/presentation/exercise/ExerciseScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
...pp/src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
...pp/src/main/java/com/example/exercisesamplecompose/presentation/goals/ExerciseGoalsScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
health-services/ExerciseSampleCompose/gradle/libs.versions.toml
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
...seSampleCompose/app/src/main/java/com/example/exercisesamplecompose/service/ExerciseState.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Aug 21, 2024
...SampleCompose/app/src/main/java/com/example/exercisesamplecompose/service/ExerciseService.kt
Show resolved
Hide resolved
breanatate
force-pushed
the
ExerciseGoals
branch
from
465016c to
e05cf07
Compare
|
You will see the force-push as a had a goof up on my fork, but will do checks to make sure all is in order. |
yschimke
approved these changes
Aug 24, 2024
yschimke
reviewed
Aug 24, 2024
| @@ -120,7 +120,7 @@ dependencies { | |||
| // Hilt | |||
| implementation libs.hilt.navigation.compose | |||
| implementation libs.dagger.hilt.android | |||
| kapt libs.dagger.hilt.android.compiler | |||
| kapt libs.dagger.hilt.android.compiler | |||
yschimke
reviewed
Aug 24, 2024
| icon = { Icon(Icons.Default.SportsScore, contentDescription = "goal achieved") }, | ||
| title = stringResource(id = R.string.goal_achieved), | ||
| showDialog = showDialog, | ||
| durationMillis = 50L, |
There was a problem hiding this comment.
Can you leave this as the default, 50ms is very short.
There was a problem hiding this comment.
Changed to DialogDefaults.LongDurationMillis
breanatate
force-pushed
the
ExerciseGoals
branch
from
e05cf07 to
a077b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Exercise Goals: