Use decltype instead of typeof, use GetSystemInfo on Windows #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is C++ code so it should use decltype instead of typeof. typeof is a C feature and often exists as a compiler specific feature (I had to replace it to __typeof__ for being able to compile) sysconf is also posix specific and does not exists in Windows and neither in MinGW so I added GetSystemInfo for that functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is C++ code so it should use
decltypeinstead oftypeof.typeofis a C feature and often exists as a compiler specific feature(I had to replace it to
__typeof__for being able to compile)sysconfis also posix specific and does not exists in Windows and neither in MinGWso I added GetSystemInfo for that functionality