refactor: 봉사 게시글 조회 메서드의 필터 파라미터를 개선한다. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존 조회 범위를 판단하기 위해 사용하던 제목, 내용, 보호소 이름 boolean 필터 대신 `KeywordCondition` 객체를 인자로 넘기도록 변경함
기존 조회 범위를 판단하기 위해 사용하던 제목, 내용 boolean 필터 대신 `KeywordConditionByShelter` 객체를 인자로 넘기도록 변경함
hseong3243
requested review from
pushedrumex,
funnysunny08 and
bjo6300
as code owners
|
pushedrumex
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
봉사글 제목,봉사글 내용,작성한 보호소 이름의 boolean 값을 인자로 넘기던 것에서KeywordCondition을 인자로 넘기도록 변경하였습니다.📝 작업 요약
titleFilter,contentFilter,shelterNameFilter파라미터를keywordCondition으로 변경💡 관련 이슈