feat: Ed25519/P256 support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
changed the title
TimoGlastra
approved these changes
Jun 12, 2024
src/EcDsaprovider.ts
Outdated
There was a problem hiding this comment.
i think the p should be capitalized in the filename?
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
ed25519-and-p-256
branch
from
a208f9f to
d86075f
Compare
added 2 commits
June 13, 2024 10:50
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is done ad-hoc so there are likely some missing features and bugs. Once the basis is all setup, I will create some tests that use the
@peculiar/x509library and see if we can achieve all the use cases.