test: x509 chain validation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
berendsliedrecht
commented
Jun 24, 2024
berendsliedrecht
commented
- tmp
- test: more x509 tests for chain validation
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
x509-tests
branch
from
9e379c0 to
cccbb67
Compare
TimoGlastra
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
I think @credo-ts/core should be a peer dependency, as we will depend on this library in core.
Even better would be to not depend on Credo in this library (as it seems lower level)
| default: | ||
| throw new core.OperationError("Only format 'jwt' is supported for importing keys") | ||
| throw new core.OperationError(`Only format 'jwt' is supported for importing keys. Received: ${format}`) |
There was a problem hiding this comment.
Suggested change
| throw new core.OperationError(`Only format 'jwt' is supported for importing keys. Received: ${format}`) | |
| throw new core.OperationError(`Only format 'jwk' and 'spki' is supported for importing keys. Received: ${format}`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.