Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add flake8 workflow #260

Closed
wants to merge 1 commit into from

Conversation

Aryamanz29
Copy link
Contributor

Description

Added workflow for Flake8

Fixes #226

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

Tested on Github.

Fail : https://github.com/Aryamanz29/bridge-in-tech-backend/actions/runs/728480082
Success : https://github.com/Aryamanz29/bridge-in-tech-backend/actions/runs/728482243

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

Copy link
Member

@codesankalp codesankalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aryamanz29 It will be better if you add info about this in README.

}

flake8-check
exit $FAILURE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new line at the end is required.

@@ -0,0 +1,3 @@
[flake8]
ignore = F401,F405,W503,F841,F403,E402,F821,W291,E266,F811
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so much error code in ignoring. If there are errors then they should be fixed in this PR.
You can consider trailing commas and import in __init__.py error code in ignoring or any other code which is required but do mention about code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codesankalp should I mention error codes .flake8 itself or in README?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just add how to run check for flake8.

@codesankalp codesankalp added Open Source Hack Status: Changes Requested Changes are required to be done by the PR author. labels Apr 8, 2021
@Aryamanz29
Copy link
Contributor Author

Please don't review this PR, I'm still working on this. I'll ping maintainers soon after fixing tests.

@devkapilbansal
Copy link
Member

@Aryamanz29 you can mark a pull request as draft if it is not ready for review. Btw, thanks for letting us know that this PR is still in progress

@Aryamanz29
Copy link
Contributor Author

Aryamanz29 commented Apr 9, 2021

@devkapilbansal While testing my code locally most unittest fails and I'm unable to debug it after several attempts, So kindly unassign this issue to me for now. I'll try to work on this issue later.

Screenshot (49)

@mtreacy002
Copy link
Member

@Aryamanz29 , have you completed the local setup #244 as requested here? If so, can you submit a pr showing the gif in the pr description as requested on the tasks?

@mtreacy002
Copy link
Member

Unassigning as per contributor's request [here]#260 (comment)).

@mtreacy002 mtreacy002 closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open Source Hack Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to follow PEP8 guidelines
4 participants