-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add flake8 workflow #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aryamanz29 It will be better if you add info about this in README.
} | ||
|
||
flake8-check | ||
exit $FAILURE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new line at the end is required.
@@ -0,0 +1,3 @@ | |||
[flake8] | |||
ignore = F401,F405,W503,F841,F403,E402,F821,W291,E266,F811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so much error code in ignoring. If there are errors then they should be fixed in this PR.
You can consider trailing commas and import in __init__.py
error code in ignoring or any other code which is required but do mention about code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codesankalp should I mention error codes .flake8
itself or in README
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No just add how to run check for flake8.
Please don't review this PR, I'm still working on this. I'll ping maintainers soon after fixing tests. |
@Aryamanz29 you can mark a pull request as draft if it is not ready for review. Btw, thanks for letting us know that this PR is still in progress |
@devkapilbansal While testing my code locally most |
@Aryamanz29 , have you completed the local setup #244 as requested here? If so, can you submit a pr showing the gif in the pr description as requested on the tasks? |
Unassigning as per contributor's request [here]#260 (comment)). |
Description
Added workflow for Flake8
Fixes #226
Type of Change:
How Has This Been Tested?
Tested on Github.
Fail : https://github.com/Aryamanz29/bridge-in-tech-backend/actions/runs/728480082
Success : https://github.com/Aryamanz29/bridge-in-tech-backend/actions/runs/728482243
Checklist:
Code/Quality Assurance Only