Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore alternative names for the Sea of Galilee #654

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kusunosetoru
Copy link
Contributor

Due to the change by #582, country_info.csv contains two lines for the Sea of Galilee.
Because of this, preexisting alternative names listed in the first line are no longer contained
in the current decks in the affected languages.

Merging the Dutch alternative name to the first one fixes this.

Copy link
Collaborator

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks!

@axelboc axelboc added this to the v5.3 milestone Oct 29, 2024
@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Oct 29, 2024
@aplaice
Copy link
Collaborator

aplaice commented Oct 31, 2024

Thanks for catching this!

(And sorry for having let this in!)

It seems to be the only duplicate
for i in src/data/*.csv
do
    csvtool cols 1 "$i" | sort | uniq -c | grep -v 1
done

returns only:

      2 Sea of Galilee

@aplaice aplaice merged commit b209944 into anki-geo:master Oct 31, 2024
1 check passed
@kusunosetoru kusunosetoru deleted the patch-1 branch October 31, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging this pull request may close these issues.

3 participants