Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Osmosis for shielded swaps #4133

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Dec 2, 2024

Describe your changes

Based on #4134

  • Implement SDK/CLI code to perform shielded swaps.
  • Integrate with the overflow receive middleware, to support directly shielding the minimum output amount of a trade on Osmosis, and sending the diff to a transient account.

Diff: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm-with-invalid-addrs..tiago/osmosis-swap-cli-over-v44

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies: (TODO, currently the new functionality is undocumented)
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 18.34862% with 801 lines in your changes missing coverage. Please review.

Project coverage is 74.10%. Comparing base (c0b9f68) to head (96e1039).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 268 Missing ⚠️
crates/sdk/src/args.rs 0.00% 193 Missing ⚠️
crates/ibc/src/context/middlewares/pfm_mod.rs 16.90% 172 Missing ⚠️
...rates/ibc/src/context/middlewares/shielded_recv.rs 22.85% 81 Missing ⚠️
crates/ibc/src/msg.rs 21.56% 40 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 21 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 63.63% 8 Missing ⚠️
crates/core/src/address.rs 40.00% 6 Missing ⚠️
crates/core/src/token.rs 0.00% 6 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 33.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4133      +/-   ##
==========================================
- Coverage   74.59%   74.10%   -0.50%     
==========================================
  Files         342      345       +3     
  Lines      108724   109649     +925     
==========================================
+ Hits        81101    81251     +150     
- Misses      27623    28398     +775     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 changed the title Susmosis... Implement Osmosis shielded swaps Dec 2, 2024
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 64e7e47 to 6fa153d Compare December 2, 2024 16:19
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 6fa153d to 59b6d2b Compare December 2, 2024 16:32
sug0 added a commit that referenced this pull request Dec 2, 2024
@sug0 sug0 marked this pull request as draft December 2, 2024 16:34
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 7c4a50d to 8ba3663 Compare December 6, 2024 11:17
@sug0 sug0 marked this pull request as ready for review December 10, 2024 13:58
@sug0 sug0 changed the title Implement Osmosis shielded swaps [draft] Implement Osmosis shielded swaps Dec 10, 2024
@sug0
Copy link
Collaborator Author

sug0 commented Dec 11, 2024

TODO add new e2e tests to CI

@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch 2 times, most recently from ac598c3 to 370ce50 Compare December 18, 2024 15:11
@sug0
Copy link
Collaborator Author

sug0 commented Dec 18, 2024

TODO: add a changelog. done in 5ecd557

this check is passing in CI, but only because we are checking the entries from the base PRs

@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch 2 times, most recently from 19bce63 to 037d931 Compare December 19, 2024 13:22
@sug0 sug0 mentioned this pull request Dec 19, 2024
@batconjurer batconjurer force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 3201926 to a4bdd73 Compare December 27, 2024 14:35
sug0 and others added 6 commits January 13, 2025 13:13
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Yuji Ito <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from e0be6e0 to 5ecd557 Compare January 13, 2025 14:37
@sug0 sug0 marked this pull request as ready for review January 13, 2025 14:37
@sug0 sug0 requested review from yito88, tzemanovic and grarco January 13, 2025 14:37
sug0 added a commit that referenced this pull request Jan 13, 2025
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 5ecd557 to 25dc477 Compare January 13, 2025 16:29
sug0 added a commit that referenced this pull request Jan 15, 2025
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 25dc477 to c15fbd8 Compare January 15, 2025 10:45
@sug0
Copy link
Collaborator Author

sug0 commented Jan 15, 2025

(f-pushed to fix a spelling mistake in the changelog)

crates/sdk/src/args.rs Show resolved Hide resolved
crates/apps_lib/src/cli.rs Show resolved Hide resolved
crates/sdk/src/rpc.rs Show resolved Hide resolved
crates/tests/src/e2e/setup.rs Outdated Show resolved Hide resolved
sug0 added a commit that referenced this pull request Jan 15, 2025
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from c15fbd8 to e4f527f Compare January 15, 2025 17:45
@sug0 sug0 requested review from tzemanovic and grarco January 15, 2025 17:46
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from e4f527f to 96e1039 Compare January 15, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants