Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ibc-rs to v0.57 #4247

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Upgrade ibc-rs to v0.57 #4247

wants to merge 18 commits into from

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jan 17, 2025

Describe your changes

based on #4134

diffs: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm-with-invalid-addrs..yuji/upgrade-ibc-rs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 56.16592% with 391 lines in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (c0b9f68) to head (7f5345e).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/context/middlewares/pfm_mod.rs 52.63% 180 Missing ⚠️
crates/ibc/src/context/common.rs 57.84% 43 Missing ⚠️
crates/ibc/src/context/nft_transfer.rs 52.00% 36 Missing ⚠️
crates/ibc/src/lib.rs 36.17% 30 Missing ⚠️
crates/ibc/src/context/client.rs 0.00% 18 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 76.00% 18 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 16.66% 15 Missing ⚠️
crates/ibc/src/context/execution.rs 63.15% 14 Missing ⚠️
crates/ibc/src/context/validation.rs 74.41% 11 Missing ⚠️
crates/sdk/src/args.rs 0.00% 9 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4247      +/-   ##
==========================================
- Coverage   74.59%   74.52%   -0.07%     
==========================================
  Files         342      344       +2     
  Lines      108724   109203     +479     
==========================================
+ Hits        81101    81382     +281     
- Misses      27623    27821     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants